कारतोफ्फेलस्क्रिप्ट™
64c0414ef2
fix(Redis Node): Add support for username auth ( #12274 )
2024-12-19 10:58:26 +01:00
Ricardo Espinoza
c4eb3746d7
refactor: Use NodeConnectionType consistently across the code base (no-changelog) ( #10595 )
2024-08-29 09:55:53 -04:00
Jon
4d37b9669f
docs: Update add options text (no-changelog) ( #10049 )
2024-07-29 13:27:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
b55fc60993
refactor(Redis Trigger Node): Refactor, fix duplicate triggers, and add unit tests ( #9850 )
2024-06-24 20:20:35 +02:00
Iván Ovejero
44ea4c73eb
refactor: Remove unused lint directives (no-changelog) ( #9842 )
2024-06-24 12:13:18 +02:00
कारतोफ्फेलस्क्रिप्ट™
ab52aaf7e9
feat(Redis Node): Update node-redis (no-changelog) ( #8269 )
...
Co-authored-by: Michael Kret <michael.k@radency.com >
2024-01-17 10:15:20 +01:00
Ricardo Espinoza
a169b74062
fix(Redis Trigger Node): Activating a workflow with a Redis trigger fails ( #8129 )
...
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.
We were awaiting for the promise to resolve before returning. Because
the trigger method does not return until the first message is received
or the connection errors, the requests that actives the workflows did
not respond making the activation button irresponsive.
Without the change:
https://www.loom.com/share/769b26d5d4ee407e999344fab3905eae
With the change:
https://www.loom.com/share/d1691ee1941248bc97f2ed97b0c129a3
## Related tickets and issues
https://linear.app/n8n/issue/ADO-895/activating-a-workflow-with-a-redis-trigger-fails
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
2023-12-21 12:29:26 -05:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) ( #5649 )
2023-03-09 18:13:15 +01:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b051478fa1633aaf84b2864f2fdc7613c.
* 👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
6608e69457
refactor(core): Remove linting exceptions in nodes-base (no-changelog) ( #4944 )
2023-01-13 18:11:56 +01:00
Michael Kret
91d7e16c81
n8n-3867-progressively-apply-prettier-to-all ( #3873 )
...
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com >
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com >
Co-authored-by: Omar Ajoue <krynble@gmail.com >
Co-authored-by: Michael Kret <michael.k@radency.com >
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com >
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com >
2022-06-20 07:54:01 -07:00
Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3dfedffd1bdccf3178af8a8d90cf5a55c.
* 👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com >
Co-authored-by: Omar Ajoue <krynble@gmail.com >
Co-authored-by: agobrech <ael.gobrecht@gmail.com >
Co-authored-by: Michael Kret <michael.k@radency.com >
2022-04-22 18:29:51 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
2022-04-15 08:00:47 +02:00
Iván Ovejero
027dfb2f0a
⚡ Enable esModuleInterop compiler option and upgrade to TypeScript 4.6 ( #3106 )
...
* ⚡ Enable `esModuleInterop` for /core
* ⚡ Adjust imports in /core
* ⚡ Enable `esModuleInterop` for /cli
* ⚡ Adjust imports in /cli
* ⚡ Enable `esModuleInterop` for /nodes-base
* ⚡ Adjust imports in /nodes-base
* ⚡ Make imports consistent
* ⬆️ Upgrade TypeScript to 4.6 (#3109 )
* ⬆️ Upgrade TypeScript to 4.6
* 📦 Update package-lock.json
* 🔧 Avoid erroring on untyped errors
* 📘 Fix type error
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com >
2022-04-08 23:32:08 +02:00
Jan Oberhauser
bb3fa05318
🐛 Fix bug in new Redis Trigger node that causes crash on activation
...
error
2022-03-12 19:22:38 +01:00
Vitaliy Fratkin
5c2deb4688
feat(Redis Node): Add Redis Trigger node and publish operation to regular node
...
* add database number select to redis credentials
* add publish to channel to redis node
* add redis trigger
* ⚡ small fixes
* ⚡ small fixes for trigger node
* fix(Strapi Node): Add support for Strapi v4
* 🐛 Fix get all operation for v4
* 🔨 Fix create operation
* 🔨 Fix update operation
* 🔨 Fix delete operation
* 🔨 Fix get operation
* 🔨 Fix Return All
* 👕 Fix nodelinter issues
* ⚡ Add Credential Test
* 🔨 Code improvement
* 👕 Fix lint issue
* Removed extra /api from Get All on v4
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com >
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com >
* refactor(editor): Replace 'Workflows' help menu item with 'Course'
* N8N-3110 Replace Workflows help menu item with course
* N8N-3110 Re-order props in en.json
* N8N-3110 Update URL Link for courses
* 🐛 Fix issue with messages being sent twice
* ⚡ Remove not needed return
Co-authored-by: Michael Kret <michael.k@radency.com >
Co-authored-by: Harshil Agrawal <ghagrawal17@gmail.com >
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com >
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com >
Co-authored-by: Oliver Trajceski <olivertrajceski@yahoo.com >
2022-03-12 12:14:39 +01:00
