Commit Graph

72 Commits

Author SHA1 Message Date
Ahsan Virani
2052cadce9 Add more frontend hooks (#1687)
*  add hook for nodecreatelist mount

*  add hook for nodeCreateList selectedTypeChanged

*  add hook for nodeCreateList nodeFilterChanged

*  add hook for nodeCreateList filteredNodeTypesComputed

*  add hook for nodeView.activeNodeChanged

*  add hook for credentialsEdit credentialTypeChanged

*  add hook for onDocumentationUrlClick

*  add hook for executionsList openDialog

*  add hook for execution open

*  add hook for credentialsList dialogVisibleChanged

*  add hook for workflowSettings

*  add hook for showMessage showError

*  add hook for nodeView createNodeActiveChanged

*  add hook for nodeView addNodeButton

*  cleanup

*  add hook for workflowRun runWorkflow

*  add hook for pushConnection executionFinished

*  add hook for runData.displayModeChanged

*  update nodeCreateList.nodeFilterChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update error data in hooks

* update workflowRun runError hook

*  Minor improvements

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-05-05 19:46:33 -05:00
Iván Ovejero
1d27a9e87e Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Jan Oberhauser
ddce679569 Minor changes to directories in binary data 2021-03-18 18:13:24 +01:00
Jan Oberhauser
d65e8ee73b 🔀 Merge branch 'binary-file-path' of https://github.com/lublak/n8n into lublak-binary-file-path 2021-03-18 13:20:26 +01:00
Jan Oberhauser
9b23611a8d Rename "Results" to "Items" 2021-03-01 14:05:19 +01:00
lublak
cb9f31c49d add dir to different positions 2021-02-15 13:25:30 +01:00
Jan Oberhauser
aaae7964d6 Keep binary data visible on re-execution 2020-12-26 23:11:25 +01:00
Jan Oberhauser
065937a39c 🐛 Fix bug that HTML did get rendered in JSON view 2020-12-24 22:09:07 +01:00
Jan
bfb344a23c Add functionality to easily copy data and path of output data (#1260)
*  Add functionality to easily copy data and path of output data

*  Fix issues with copied path

* 👕 Fix lint issue

* ;bug: Fix issue that some paths were wrong

*  Final improvements
2020-12-18 18:55:53 +01:00
maxtkacz
f386d9e90a Made "easy wins" copy-edit pass through vue components (#889)
Essentially scrubbed through .vue files in packages/editor-ui/src/components and copy edited labels/ tooltips etc.

Tried to prevent opinionated editing, simply rewriting existing meaning for clarity. I did however make an opinionated decision on changing a node's "Notes" to "Note" (only labels, nothing code related) because it feels more like a singluar note - especially when used as a subtitle in the workflow. Singular form also futureproofs functionality like showing a list of all node notes across a workflow (or versioning/ collaborative notes features).

So far, have gotten up to PageContentWrapper.vue (when sorted alphabetically). In a followup, will review ParameterInput.vue and onwards in /components folder
2020-08-26 21:25:59 +02:00
Jan Oberhauser
c298fd325a 🐛 Fix bug which displayed selector for low number of items 2020-07-29 22:43:05 +02:00
Jan Oberhauser
305894d9b4 🐛 Fix item display issue 2020-07-10 10:12:30 +02:00
Jan Oberhauser
2cdfb69e0c Improve data display for large amount of data 2020-05-24 00:57:40 +02:00
Jan Oberhauser
c6281f2b0e Use only JSON-Data for display-size-calculation 2020-05-23 23:54:56 +02:00
Jan Oberhauser
1ed5a4589d Improve handling of incorrect return data of Function Nodes 2019-12-23 14:54:27 -06:00
Jan Oberhauser
862b693c0a Fix issue that items got displayed twice in JSON-View 2019-11-23 10:23:26 +01:00
Jan Oberhauser
edf216ba24 💄 Display new line in JSON data 2019-11-16 23:42:18 +01:00
Jan Oberhauser
199e7a7a2c Improve hiding of large data 2019-10-04 13:27:50 +02:00
Jan Oberhauser
295bd212ce 🐛 Fix issue that JSON view could not be selected anymore 2019-10-04 12:34:09 +02:00
Jan Oberhauser
50b23f1fc4 If node contains large amount of data hide it first by default 2019-10-02 15:30:51 +02:00
Jan Oberhauser
3d80d9602e 💄 Improve display of output- and execution-selection 2019-06-27 14:07:45 +02:00
Jan Oberhauser
9cb9804eee Initial commit to release 2019-06-23 12:35:23 +02:00