Commit Graph

74 Commits

Author SHA1 Message Date
Ricardo Espinoza
cdfa22593b fix(Code Node): Do not validate code within comments (#12938) 2025-01-30 09:44:35 -05:00
Iván Ovejero
1b9100032f fix(core): Allow index as top-level item key for Code node (#12469) 2025-01-06 15:03:36 +01:00
कारतोफ्फेलस्क्रिप्ट™
39d5e0ff87 refactor(core): Replace typedi with our custom DI system (no-changelog) (#12389)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2025-01-06 10:21:24 +01:00
कारतोफ्फेलस्क्रिप्ट™
bafac73eb5 refactor: Impose import/order linting rule across nodes packages (no-changelog) (#12314) 2024-12-19 18:46:14 +01:00
Iván Ovejero
aece4c497a chore(core): Stop reporting TypeError and AttributeError from Python sandbox to Sentry (#12078) 2024-12-09 09:17:26 +01:00
Michael Kret
3a5bd12945 feat(Code Node): Warning if pairedItem absent or could not be auto mapped (#11737)
Co-authored-by: Shireen Missi <shireen@n8n.io>
2024-11-27 16:31:36 +00:00
कारतोफ्फेलस्क्रिप्ट™
f6c0d045e9 fix(core): Don't use unbound context methods in code sandboxes (#11914) 2024-11-27 12:08:16 +01:00
Tomi Turtiainen
e22d0f3877 perf(core): Batch items sent in runonceforeachitem mode (no-changelog) (#11870)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-11-26 12:21:51 +02:00
Tomi Turtiainen
d25ae8e0d9 refactor: Rename disabled to enabled in runner config (#11621) 2024-11-07 14:22:43 +02:00
Tomi Turtiainen
4e3681b905 fix: Provide a better error message when task runner disconnects (no-changelog) (#11442) 2024-10-29 12:39:31 +02:00
कारतोफ्फेलस्क्रिप्ट™
8f5fe05a92 refactor(core): All calls to supplyData should use a distinct context type (no-changelog) (#11421) 2024-10-28 11:37:23 +01:00
Tomi Turtiainen
0708b3a1f8 fix: Include error in the message in JS task runner sandbox (#11359) 2024-10-23 12:13:09 +03:00
Iván Ovejero
8e5292cf6c chore: Upgrade nodelinter to 1.16.3 (#11286) 2024-10-18 09:22:24 +02:00
Tomi Turtiainen
d330b6b94a fix: Fix task runner error propagation (no-changelog) (#11291) 2024-10-17 14:17:33 +03:00
Tomi Turtiainen
1078fa662a fix: Make sure errors are transferred correctly from js task runner (no-changelog) (#11214) 2024-10-10 21:01:38 +03:00
Tomi Turtiainen
2bb1996738 feat: Add once for each item support for JS task runner (no-changelog) (#11109) 2024-10-07 21:18:32 +03:00
Val
27d83e0d91 feat: Initial Code Task Runners support (no-changelog) (#10698)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2024-10-02 09:31:56 +01:00
Michael Kret
9fa1a9aa99 fix: Disable errors obfuscation (no-changelog) (#10617) 2024-08-30 10:59:30 +03:00
Ricardo Espinoza
c4eb3746d7 refactor: Use NodeConnectionType consistently across the code base (no-changelog) (#10595) 2024-08-29 09:55:53 -04:00
कारतोफ्फेलस्क्रिप्ट™
7e95f9e2e4 fix(core): VM2 sandbox should not throw on new Promise (#10298) 2024-08-06 15:16:33 +02:00
Michael Kret
e2dd000d13 fix: Prevent errors processed by n8n to be flagged as internal (no-changelog) (#10023) 2024-07-12 11:13:17 +03:00
Michael Kret
b7aea957b8 feat: Do not show errors not processed by n8n (no-changelog) (#9598)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-06-20 08:45:00 +03:00
कारतोफ्फेलस्क्रिप्ट™
2bdc459bb2 refactor(core): Fix type errors in workflow, core, nodes-langchain, and nodes-base (no-changelog) (#9450) 2024-05-22 17:40:52 +02:00
कारतोफ्फेलस्क्रिप्ट™
82c8801f25 fix(Code Node): Bind helper methods to the correct context (#9380) 2024-05-14 14:08:51 +02:00
कारतोफ्फेलस्क्रिप्ट™
372d5c7d01 ci: Upgrade eslint, prettier, typescript, and some other dev tooling (no-changelog) (#8895)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-03-26 14:22:57 +01:00
Giulio Andreini
5301323906 feat(editor): Improve errors in output panel (#8644)
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-03-07 18:08:01 +02:00
Giulio Andreini
95e4c4fbb3 docs(editor): Nodes icons, Merge node descriptions (#8517)
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2024-02-21 16:04:57 +00:00
Tomi Turtiainen
9a1cc56806 fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Elias Meire
071e6d6b6e feat(editor): Add fullscreen view to code editor (#8084)
## Summary

<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe">

1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed

It should work the same way for HTML/SQL/JSON editors

⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals

## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Elias Meire
675ec21d33 feat: Data transformation nodes and actions in Nodes Panel (#7760)
- Split Items List node into separate nodes per action
- Review node descriptions
- New icons
- New sections in subcategories

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-08 11:40:05 +01:00
Iván Ovejero
e77fd5d286 refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.

Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877)

- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-05 11:17:08 +01:00
Deborah
485a0c73cb docs: Fix typo in tooltip relating to JMESPath (#7910) 2023-12-04 08:19:36 +00:00
Jan Oberhauser
87def60979 feat: Add AI tool building capabilities (#7336)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-29 12:13:55 +01:00
Csaba Tuncsik
e128b23a2b build: Upgrade to Vite 5 (#7784) 2023-11-23 11:55:02 +01:00
Jan Oberhauser
655efeaf66 feat(core): Add optional Error-Output (#7460)
Add an additional optional error output to which all items get sent that
could not be processed.
![Screenshot from 2023-10-18
17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094

https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791

---------

Co-authored-by: OlegIvaniv <me@olegivaniv.com>
2023-10-30 18:42:47 +01:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Iván Ovejero
6d6e2488c6 refactor(core): Generalize binary data manager interface (no-changelog) (#7164)
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768)

This PR: 
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.

Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.

Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
Michael Kret
3a474552b2 feat(Set Node): Overhaul (#6348)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
कारतोफ्फेलस्क्रिप्ट™
36a8e911e6 fix(Code Node): Disable WASM to address CVE-2023-37903 (#7122)
[GH Advisory](https://github.com/advisories/GHSA-g644-9gfx-q4q4)
2023-09-06 16:11:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473 refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
dfe0fa65f8 fix(Code Node): Switch over to vm2 fork (#7018)
[Fork is here](https://github.com/n8n-io/vm2). Currently there are no
modifications in it.
2023-08-30 11:17:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
0356419c1a feat(Code Node)!: Add a flag to disable forwarding of code logging to stdout (#6966) 2023-08-25 14:23:23 +02:00
Ian Gallagher
258e0ebb0f docs(Code Node): Update description to include Python (no-changelog) (#6904) 2023-08-10 11:23:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
f718c2291f fix(Code Node): Consistent redirection of stdout for JS and Python sandboxes (#6818)
Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 17:47:43 +02:00
Iván Ovejero
24ce141815 refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812)
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)

* removed unused disable directives

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
e57e85edf7 refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) 2023-07-12 11:15:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
bf351243df fix(Code Node): Install python modules always in a user-writable folder (#6568)
* upgrade pyodide

* install pyodide modules to a custom user-writable path

* in `augmentObject` `newData` is never undefined
2023-07-07 16:43:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
f6366160a4 feat(core): Remove conditional defaults in V1 release (#6363) 2023-06-22 19:54:32 +02:00
कारतोफ्फेलस्क्रिप्ट™
54e3838dae fix(Code Node): Fix item and items alias regression (#6331) 2023-05-30 12:56:55 +02:00
कारतोफ्फेलस्क्रिप्ट™
bcbec52552 fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318)
GH advisory: https://github.com/advisories/GHSA-p5gc-c584-jj6v
2023-05-25 12:55:53 +02:00