admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-21 11:49:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(editor): Rename renameDefaultNodeName (no-changelog) (#19094)

Browse Source
This commit is contained in:
Charlie Kolb
2025-09-02 15:43:26 +02:00
committed by GitHub
parent c72acf901f
commit 57baa10fa4
3 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue
View File

@@ -92,7 +92,7 @@ const {
searchFilter, searchFilter,
onSearchFilter, onSearchFilter,
getWorkflowName, getWorkflowName,
renameDefaultNodeName, applyDefaultExecuteWorkflowNodeName,
populateNextWorkflowsPage, populateNextWorkflowsPage,
setWorkflowsResources, setWorkflowsResources,
reloadWorkflows, reloadWorkflows,
@@ -178,7 +178,7 @@ function onListItemSelected(value: NodeParameterValue) {
// we rename defaults here to allow selecting the same workflow to // we rename defaults here to allow selecting the same workflow to
// update the name, as we don't eagerly update a changed workflow name // update the name, as we don't eagerly update a changed workflow name
// but rather only react on changed id elsewhere // but rather only react on changed id elsewhere
renameDefaultNodeName(value); applyDefaultExecuteWorkflowNodeName(value);
} }
function onInputFocus(): void { function onInputFocus(): void {
@@ -252,7 +252,7 @@ watch(
// changed name means the workflow becomes unsaved and changed just by // changed name means the workflow becomes unsaved and changed just by
// opening the ExecuteWorkflow node referencing the renamed workflow // opening the ExecuteWorkflow node referencing the renamed workflow
if (old.value !== val.value) { if (old.value !== val.value) {
renameDefaultNodeName(val.value); applyDefaultExecuteWorkflowNodeName(val.value);
} }
}, },
); );

18
packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.test.ts
View File

@@ -30,7 +30,7 @@ describe('useWorkflowResourcesLocator', () => {
useCanvasOperations.mockReturnValue({ renameNode: renameNodeMock }); useCanvasOperations.mockReturnValue({ renameNode: renameNodeMock });
}); });
describe('renameDefaultNodeName', () => { describe('applyDefaultExecuteWorkflowNodeName', () => {
it.each([ it.each([
{ {
activeNodeName: 'Execute Workflow', activeNodeName: 'Execute Workflow',
@@ -56,14 +56,14 @@ describe('useWorkflowResourcesLocator', () => {
])( ])(
'should rename the node correctly for activeNodeName: $activeNodeName', 'should rename the node correctly for activeNodeName: $activeNodeName',
({ activeNodeName, workflowId, mockedWorkflow, expectedRename, expectedCalledWith }) => { ({ activeNodeName, workflowId, mockedWorkflow, expectedRename, expectedCalledWith }) => {
const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock);
ndvStoreMock.activeNodeName = activeNodeName; ndvStoreMock.activeNodeName = activeNodeName;
workflowsStoreMock.getWorkflowById.mockReturnValue( workflowsStoreMock.getWorkflowById.mockReturnValue(
mockedWorkflow as unknown as IWorkflowDb, mockedWorkflow as unknown as IWorkflowDb,
); );
renameDefaultNodeName(workflowId); applyDefaultExecuteWorkflowNodeName(workflowId);
expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId); expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId);
expect(renameNodeMock).toHaveBeenCalledWith(expectedCalledWith, expectedRename); expect(renameNodeMock).toHaveBeenCalledWith(expectedCalledWith, expectedRename);
@@ -71,30 +71,30 @@ describe('useWorkflowResourcesLocator', () => {
); );
it('should not rename the node for invalid workflowId', () => { it('should not rename the node for invalid workflowId', () => {
const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock);
const workflowId = 123; const workflowId = 123;
renameDefaultNodeName(workflowId); applyDefaultExecuteWorkflowNodeName(workflowId);
expect(renameNodeMock).not.toHaveBeenCalled(); expect(renameNodeMock).not.toHaveBeenCalled();
}); });
it('should not rename the node for workflowId: workflow-id with null mockedWorkflow', () => { it('should not rename the node for workflowId: workflow-id with null mockedWorkflow', () => {
const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock);
const workflowId = 'workflow-id'; const workflowId = 'workflow-id';
const activeNodeName = 'Execute Workflow'; const activeNodeName = 'Execute Workflow';
ndvStoreMock.activeNodeName = activeNodeName; ndvStoreMock.activeNodeName = activeNodeName;
workflowsStoreMock.getWorkflowById.mockReturnValue(null as unknown as IWorkflowDb); workflowsStoreMock.getWorkflowById.mockReturnValue(null as unknown as IWorkflowDb);
renameDefaultNodeName(workflowId); applyDefaultExecuteWorkflowNodeName(workflowId);
expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId); expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId);
expect(renameNodeMock).not.toHaveBeenCalled(); expect(renameNodeMock).not.toHaveBeenCalled();
}); });
it('should not rename the node for workflowId: workflow-id with activeNodeName: Some Other Node', () => { it('should not rename the node for workflowId: workflow-id with activeNodeName: Some Other Node', () => {
const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock);
const workflowId = 'workflow-id'; const workflowId = 'workflow-id';
const activeNodeName = 'Some Other Node'; const activeNodeName = 'Some Other Node';
const mockedWorkflow = { name: 'Test Workflow' }; const mockedWorkflow = { name: 'Test Workflow' };
@@ -102,7 +102,7 @@ describe('useWorkflowResourcesLocator', () => {
ndvStoreMock.activeNodeName = activeNodeName; ndvStoreMock.activeNodeName = activeNodeName;
workflowsStoreMock.getWorkflowById.mockReturnValue(mockedWorkflow as unknown as IWorkflowDb); workflowsStoreMock.getWorkflowById.mockReturnValue(mockedWorkflow as unknown as IWorkflowDb);
renameDefaultNodeName(workflowId); applyDefaultExecuteWorkflowNodeName(workflowId);
expect(workflowsStoreMock.getWorkflowById).not.toHaveBeenCalled(); expect(workflowsStoreMock.getWorkflowById).not.toHaveBeenCalled();
expect(renameNodeMock).not.toHaveBeenCalled(); expect(renameNodeMock).not.toHaveBeenCalled();

4
packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts
View File

@@ -95,7 +95,7 @@ export function useWorkflowResourcesLocator(router: Router) {
searchFilter.value = filter; searchFilter.value = filter;
} }
function renameDefaultNodeName(workflowId: NodeParameterValue) { function applyDefaultExecuteWorkflowNodeName(workflowId: NodeParameterValue) {
if (typeof workflowId !== 'string') return; if (typeof workflowId !== 'string') return;
const nodeName = ndvStore.activeNodeName; const nodeName = ndvStore.activeNodeName;
@@ -121,7 +121,7 @@ export function useWorkflowResourcesLocator(router: Router) {
getWorkflowUrl, getWorkflowUrl,
onSearchFilter, onSearchFilter,
getWorkflowName, getWorkflowName,
renameDefaultNodeName, applyDefaultExecuteWorkflowNodeName,
populateNextWorkflowsPage, populateNextWorkflowsPage,
setWorkflowsResources, setWorkflowsResources,
}; };