admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-16 09:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Migrate 28-resource-mapper to playwright (no-changelog) (#18944)

Browse Source
This commit is contained in:
Svetoslav Dekov
2025-08-29 14:14:38 +03:00
committed by GitHub
parent e273afdaa8
commit f1c52461cf
5 changed files with 127 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
cypress/e2e/28-resource-mapper.cy.ts
View File

@@ -1,95 +0,0 @@
import { WorkflowPage, NDV } from '../pages';
const workflowPage = new WorkflowPage();
const ndv = new NDV();
describe('Resource Mapper', () => {
beforeEach(() => {
workflowPage.actions.visit();
});
it('should not retrieve list options when required params throw errors', () => {
workflowPage.actions.addInitialNodeToCanvas('E2e Test', {
action: 'Resource Mapping Component',
});
ndv.getters
.resourceMapperFieldsContainer()
.should('be.visible')
.findChildByTestId('parameter-input')
.should('have.length', 3);
ndv.actions.setInvalidExpression({ fieldName: 'fieldId' });
ndv.actions.refreshResourceMapperColumns();
ndv.getters.resourceMapperFieldsContainer().should('not.exist');
});
it('should retrieve list options when optional params throw errors', () => {
workflowPage.actions.addInitialNodeToCanvas('E2e Test', {
action: 'Resource Mapping Component',
});
ndv.getters
.resourceMapperFieldsContainer()
.should('be.visible')
.findChildByTestId('parameter-input')
.should('have.length', 3);
ndv.actions.setInvalidExpression({ fieldName: 'otherField' });
ndv.actions.refreshResourceMapperColumns();
ndv.getters
.resourceMapperFieldsContainer()
.should('be.visible')
.findChildByTestId('parameter-input')
.should('have.length', 3);
});
it('should correctly delete single field', () => {
workflowPage.actions.addInitialNodeToCanvas('E2e Test', {
action: 'Resource Mapping Component',
});
ndv.getters.parameterInput('id').type('001');
ndv.getters.parameterInput('name').type('John');
ndv.getters.parameterInput('age').type('30');
ndv.getters.nodeExecuteButton().click();
ndv.getters.outputTableHeaderByText('id').should('exist');
ndv.getters.outputTableHeaderByText('name').should('exist');
ndv.getters.outputTableHeaderByText('age').should('exist');
// Remove the 'name' field
ndv.getters.resourceMapperRemoveFieldButton('name').should('exist').click({ force: true });
ndv.getters.nodeExecuteButton().click();
ndv.getters.parameterInput('id').should('exist');
ndv.getters.outputTableHeaderByText('id').should('exist');
// After removing the field, text field and the output table column for the 'name' should not be there anymore
ndv.getters.parameterInput('age').should('exist');
ndv.getters.outputTableHeaderByText('age').should('exist');
ndv.getters.parameterInput('name').should('not.exist');
ndv.getters.outputTableHeaderByText('name').should('not.exist');
});
it('should correctly delete all fields', () => {
workflowPage.actions.addInitialNodeToCanvas('E2e Test', {
action: 'Resource Mapping Component',
});
ndv.getters.parameterInput('id').type('001');
ndv.getters.parameterInput('name').type('John');
ndv.getters.parameterInput('age').type('30');
ndv.getters.nodeExecuteButton().click();
ndv.getters.outputTableHeaderByText('id').should('exist');
ndv.getters.outputTableHeaderByText('name').should('exist');
ndv.getters.outputTableHeaderByText('age').should('exist');
ndv.getters.resourceMapperColumnsOptionsButton().click();
// Click on the 'Remove All Fields' option
ndv.getters.resourceMapperRemoveAllFieldsOption().should('be.visible').click();
ndv.getters.nodeExecuteButton().click();
ndv.getters.parameterInput('id').should('exist');
ndv.getters.outputTableHeaderByText('id').should('exist');
// After removing the all fields, only required one should be in UI and output table
ndv.getters.parameterInput('name').should('not.exist');
ndv.getters.outputTableHeaderByText('name').should('not.exist');
ndv.getters.parameterInput('age').should('not.exist');
ndv.getters.outputTableHeaderByText('age').should('not.exist');
});
});

1
packages/frontend/editor-ui/src/components/ParameterInputFull.vue
View File

@@ -318,6 +318,7 @@ function removeOverride(clearField = false) {
:options-position="optionsPosition"
:bold="false"
:size="label.size"
:input-name="parameter.name"
color="text-dark"
@mouseenter="onWrapperMouseEnter"
@mouseleave="onWrapperMouseLeave"

1
packages/testing/playwright/config/constants.ts
View File

@@ -38,6 +38,7 @@ export const NEW_GOOGLE_ACCOUNT_NAME = 'Gmail account';
export const NEW_TRELLO_ACCOUNT_NAME = 'Trello account';
export const NEW_NOTION_ACCOUNT_NAME = 'Notion account';
export const NEW_QUERY_AUTH_ACCOUNT_NAME = 'Query Auth account';
export const E2E_TEST_NODE_NAME = 'E2E Test';
export const ROUTES = {
NEW_WORKFLOW_PAGE: '/workflow/new',

51
packages/testing/playwright/pages/NodeDetailsViewPage.ts
View File

@@ -70,6 +70,19 @@ export class NodeDetailsViewPage extends BasePage {
return this.page.getByTestId('parameter-expression-preview-value');
}
getInlineExpressionEditorPreview() {
return this.page.getByTestId('inline-expression-editor-output');
}
async activateParameterExpressionEditor(parameterName: string) {
const parameterInput = this.getParameterInput(parameterName);
await parameterInput.click();
await this.page
.getByTestId(`${parameterName}-parameter-input-options-container`)
.getByTestId('radio-button-expression')
.click();
}
getEditPinnedDataButton() {
return this.page.getByTestId('ndv-edit-pinned-data');
}
@@ -210,7 +223,7 @@ export class NodeDetailsViewPage extends BasePage {
* @param parameterName - The name of the parameter
*/
getParameterInputField(parameterName: string) {
return this.getParameterInput(parameterName).getByTestId('parameter-input-field');
return this.getParameterInput(parameterName).locator('input');
}
/**
@@ -267,9 +280,7 @@ export class NodeDetailsViewPage extends BasePage {
* Ported from Cypress pattern with Playwright selectors
*/
getVisiblePopper() {
return this.page
.locator('.el-popper')
.filter({ hasNot: this.page.locator('[aria-hidden="true"]') });
return this.page.locator('.el-popper:visible');
}
/**
@@ -517,6 +528,38 @@ export class NodeDetailsViewPage extends BasePage {
.getByTestId('assignment-name');
}
getResourceMapperFieldsContainer() {
return this.page.getByTestId('mapping-fields-container');
}
getResourceMapperParameterInputs() {
return this.getResourceMapperFieldsContainer().getByTestId('parameter-input');
}
getResourceMapperSelectColumn() {
return this.page.getByTestId('matching-column-select');
}
getResourceMapperColumnsOptionsButton() {
return this.page.getByTestId('columns-parameter-input-options-container');
}
getResourceMapperRemoveFieldButton(fieldName: string) {
return this.page.getByTestId(`remove-field-button-${fieldName}`);
}
getResourceMapperRemoveAllFieldsOption() {
return this.page.getByTestId('action-removeAllFields');
}
async refreshResourceMapperColumns() {
const selectColumn = this.getResourceMapperSelectColumn();
await selectColumn.hover();
await selectColumn.getByTestId('action-toggle').click();
await expect(this.getVisiblePopper().getByTestId('action-refreshFieldList')).toBeVisible();
await this.getVisiblePopper().getByTestId('action-refreshFieldList').click();
}
getAddValueButton() {
return this.getNodeParameters().locator('input[placeholder*="Add Value"]');
}

78
packages/testing/playwright/tests/ui/28-resource-mapper.spec.ts Normal file
View File

@@ -0,0 +1,78 @@
import { E2E_TEST_NODE_NAME } from '../../config/constants';
import { test, expect } from '../../fixtures/base';
test.describe('Resource Mapper', () => {
test.beforeEach(async ({ n8n }) => {
await n8n.goHome();
await n8n.workflows.clickAddWorkflowButton();
await n8n.canvas.addNode(E2E_TEST_NODE_NAME, { action: 'Resource Mapping Component' });
});
test('should not retrieve list options when required params throw errors', async ({ n8n }) => {
const fieldsContainer = n8n.ndv.getResourceMapperFieldsContainer();
await expect(fieldsContainer).toBeVisible();
await expect(n8n.ndv.getResourceMapperParameterInputs()).toHaveCount(3);
await n8n.ndv.activateParameterExpressionEditor('fieldId');
await n8n.ndv.typeInExpressionEditor("{{ $('unknown')");
await expect(n8n.ndv.getInlineExpressionEditorPreview()).toContainText("node doesn't exist");
await n8n.ndv.refreshResourceMapperColumns();
await expect(n8n.ndv.getResourceMapperFieldsContainer()).toHaveCount(0);
});
test('should retrieve list options when optional params throw errors', async ({ n8n }) => {
await n8n.ndv.activateParameterExpressionEditor('otherField');
await n8n.ndv.typeInExpressionEditor("{{ $('unknown')");
await expect(n8n.ndv.getInlineExpressionEditorPreview()).toContainText("node doesn't exist");
await n8n.ndv.refreshResourceMapperColumns();
await expect(n8n.ndv.getResourceMapperFieldsContainer()).toBeVisible();
await expect(n8n.ndv.getResourceMapperParameterInputs()).toHaveCount(3);
});
test('should correctly delete single field', async ({ n8n }) => {
await n8n.ndv.fillParameterInputByName('id', '001');
await n8n.ndv.fillParameterInputByName('name', 'John');
await n8n.ndv.fillParameterInputByName('age', '30');
await n8n.ndv.execute();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'id' })).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'name' })).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'age' })).toBeVisible();
await n8n.ndv.getResourceMapperRemoveFieldButton('name').click();
await n8n.ndv.execute();
await expect(n8n.ndv.getParameterInput('id')).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'id' })).toBeVisible();
await expect(n8n.ndv.getParameterInput('age')).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'age' })).toBeVisible();
await expect(n8n.ndv.getParameterInput('name')).toHaveCount(0);
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'name' })).toHaveCount(0);
});
test('should correctly delete all fields', async ({ n8n }) => {
await n8n.ndv.fillParameterInputByName('id', '001');
await n8n.ndv.fillParameterInputByName('name', 'John');
await n8n.ndv.fillParameterInputByName('age', '30');
await n8n.ndv.execute();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'id' })).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'name' })).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'age' })).toBeVisible();
await n8n.ndv.getResourceMapperColumnsOptionsButton().click();
await n8n.ndv.getResourceMapperRemoveAllFieldsOption().click();
await n8n.ndv.execute();
await expect(n8n.ndv.getParameterInput('id')).toBeVisible();
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'id' })).toBeVisible();
await expect(n8n.ndv.getParameterInput('name')).toHaveCount(0);
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'name' })).toHaveCount(0);
await expect(n8n.ndv.getParameterInput('age')).toHaveCount(0);
await expect(n8n.ndv.getOutputTableHeaders().filter({ hasText: 'age' })).toHaveCount(0);
});
});