When ever we have migrations that use `.addColumn` or `.dropColumn`,
typeorm recreates tables for sqlite. so, we need to disable foreign key
enforcement for sqlite, or else data in some tables can get deleted
because of `ON DELETE CASCADE`
[This has happened in the
past](https://github.com/n8n-io/n8n/pull/6739), and we should really
come up with a way to prevent this from happening again.
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Github issue / Community forum post (link here to close automatically):
This PR aims to address an issue where an Error workflow cannot be
started, either due to insufficient permissions or because its settings
prevent it from being called.
The way of addressing this is by creating a failed execution for the
appointed error workflow stating the error, as can be seen below.
This means the execution itself won't start, as it's prevented before
the execution beings, but we save a "stub" execution to show the error.
In scope:
- Consolidate `WorkflowService.getMany()`.
- Support non-entity field `ownedBy` for `select`.
- Support `tags` for `filter`.
- Move `addOwnerId` to `OwnershipService`.
- Remove unneeded check for `filter.id`.
- Simplify DTO validation for `filter` and `select`.
- Expand tests for `GET /workflows`.
Workflow list query DTOs:
```
filter → name, active, tags
select → id, name, active, tags, createdAt, updatedAt, versionId, ownedBy
```
Out of scope:
- Migrate `shared_workflow.roleId` and `shared_credential.roleId` to
string IDs.
- Refactor `WorkflowHelpers.getSharedWorkflowIds()`.
Issue: during startup, unfinished executions trigger a recovery process
that, under certain circumstances, can in itself crash the instance
(e.g. by running our of memory), resulting in an infinite recovery loop
This PR aims to change this behaviour by writing a flag file when the
recovery process starts, and removing it when it finishes. In the case
of a crash, this flag will persist and upon the next attempt, the
recovery will instead do the absolute minimal (marking executions as
'crashed'), without attempting any 'crashable' actions.
On Prettier 3, VSCode Prettier extension v10.1.0 fails to load the
Prettier config file.
<details>
<summary>
Stack trace
</summary>
```
["INFO" - 10:24:08] Extension Name: esbenp.prettier-vscode.
["INFO" - 10:24:08] Extension Version: 10.1.0.
["ERROR" - 10:24:08] Error resolving prettier configuration for /Users/ivov/Development/n8n
["ERROR" - 10:24:08] Invalid host defined options
TypeError: Invalid host defined options
at Object.<anonymous> (/Users/ivov/Development/n8n/node_modules/.pnpm/prettier@3.0.0/node_modules/prettier/index.cjs:600:23)
at Module.u._compile (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:1271)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1243:10)
at Module.load (node:internal/modules/cjs/loader:1058:32)
at Module._load (node:internal/modules/cjs/loader:893:12)
at Function.f._load (node:electron/js2c/asar_bundle:2:13330)
at Function.l._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:28070)
at Function.p._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:25404)
at Function.u._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:91:22191)
at Module.apply (node:internal/modules/cjs/loader:1082:19)
at Module.require (/Users/ivov/.vscode/extensions/github.copilot-1.103.338/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
at g (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:647)
at t.loadNodeModule (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:2829)
at t.PrettierMainThreadInstance.import (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:17760)
at t.ModuleResolver.getPrettierInstance (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:5728)
at t.default.handleActiveTextEditorChanged (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:10771)
at t.default.handleActiveTextEditorChangedSync (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:10373)
at t.default.registerDisposables (/Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:13531)
at /Users/ivov/.vscode/extensions/esbenp.prettier-vscode-10.1.0/dist/extension.js:1:82528
```
</details>
Removing `prettier.prettierPath` allows the config file to be found
again. But from what I can tell, this option was not deprecated. So on
review, please validate that this works on your own setup as well.
